linux-kernel - Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61791002-0928-fa79-8cba-9625eb0418dd@linux.intel.com>
Date:   Tue, 12 Feb 2019 21:20:36 +0800
From:   "Li, Aubrey" <aubrey.li@...ux.intel.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     mingo@...hat.com, peterz@...radead.org, hpa@...or.com,
        ak@...ux.intel.com, tim.c.chen@...ux.intel.com,
        dave.hansen@...el.com, arjan@...ux.intel.com, aubrey.li@...el.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed
 time

On 2019/2/12 21:03, Thomas Gleixner wrote:
> On Tue, 12 Feb 2019, Aubrey Li wrote:
> 
> arch/x86/kernel/fpu/xstate.c:1252:6: warning: no previous prototype for ‘avx512_status’ [-Wmissing-prototypes]
>  void avx512_status(struct seq_file *m, struct task_struct *task)
>       ^~~~~~~~~~~~~
Sorry for this warning, I didn't see it on my side. May I know how to open this knob?

> arch/x86/kernel/fpu/xstate.c: In function ‘avx512_status’:
> arch/x86/kernel/fpu/xstate.c:1254:44: error: ‘struct fpu’ has no member named ‘avx512_timestamp’
>   unsigned long timestamp = task->thread.fpu.avx512_timestamp;

I didn't include the first patch, because I saw it's already in tip tree. Did you use tip tree?

>                                             ^
> arch/x86/kernel/fpu/xstate.c: At top level:
> arch/x86/kernel/fpu/xstate.c:1279:6: warning: no previous prototype for ‘arch_proc_pid_status’ [-Wmissing-prototypes]
>  void arch_proc_pid_status(struct seq_file *m, struct task_struct *task)
>       ^~~~~~~~~~~~~~~~~~~~
Sorry for this, May I know how to replicate it on my side?

Thanks,
-Aubrey