linux-kernel - Re: Oops in rpc_clnt_debugfs_register() from debugfs change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21212.1549983454@warthog.procyon.org.uk>
Date:   Tue, 12 Feb 2019 14:57:34 +0000
From:   David Howells <dhowells@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     dhowells@...hat.com, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, mhiramat@...nel.org,
        bigeasy@...utronix.de
Subject: Re: Oops in rpc_clnt_debugfs_register() from debugfs change

Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> -	if (!xprt->debugfs) {
> +	if (IS_ERR_OR_NULL(xprt->debugfs)) {

That works, though I don't much like the idea of there being an error there.

Looking in rpc_xprt_debugfs_register() there are two now-dodgy looking checks
on the result of debugfs calls.

David