linux-kernel - Re: [PATCH] iommu/ipmmu-vmsa: fix device reference leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190212164722.GT6279@pendragon.ideasonboard.com>
Date:   Tue, 12 Feb 2019 18:47:22 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     "joro@...tes.org" <joro@...tes.org>
Cc:     wen yang <yellowriver2010@...mail.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Magnus Damm <damm+renesas@...nsource.se>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: fix device reference leaks

Hello,

Wen, thank you for the patch.

On Mon, Feb 11, 2019 at 11:24:15AM +0100, joro@...tes.org wrote:
> Adding a few more people to Cc.
> 
> On Sun, Feb 03, 2019 at 10:27:09AM +0000, wen yang wrote:
> > Make sure to drop the reference to the device taken by
> > of_find_device_by_node() on driver unbind.
> > 
> > Signed-off-by: Wen Yang <yellowriver2010@...mail.com>
> > Cc: Joerg Roedel <joro@...tes.org>
> > Cc: iommu@...ts.linux-foundation.org
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  drivers/iommu/ipmmu-vmsa.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> > index 7a4529c..cebf56d 100644
> > --- a/drivers/iommu/ipmmu-vmsa.c
> > +++ b/drivers/iommu/ipmmu-vmsa.c
> > @@ -756,6 +756,9 @@ static int ipmmu_init_platform_device(struct device *dev,
> >  
> >  	fwspec->iommu_priv = platform_get_drvdata(ipmmu_pdev);
> >  
> > +	if (!fwspec->iommu_priv)
> > +		put_device(&ipmmu_pdev->dev);
> > +

This doesn't seem to match the patch's subject, and doesn't seem to fix
the problem.

> >  	return 0;
> >  }
> >  

-- 
Regards,

Laurent Pinchart