lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Feb 2019 18:14:19 +0100 From: Frederic Weisbecker <frederic@...nel.org> To: LKML <linux-kernel@...r.kernel.org> Cc: Frederic Weisbecker <frederic@...nel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Mauro Carvalho Chehab <mchehab@...pensource.com>, Linus Torvalds <torvalds@...ux-foundation.org>, "David S . Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>, Frederic Weisbecker <fweisbec@...il.com>, Pavan Kondeti <pkondeti@...eaurora.org>, Ingo Molnar <mingo@...nel.org>, Joel Fernandes <joel@...lfernandes.org> Subject: [PATCH 28/32] locking/lockdep: Update check_flags() according to new layout current->softirqs_enabled used to mean that either all or no softirqs are enabled. Now things are getting a bit different with the new per vector masking extension after which current->softirqs_enabled will stay on as long as there is a single vector still enabled. Let's adapt the check to the updated semantics. We can't deduce much from softirq_count() alone anymore except when it's 0. Signed-off-by: Frederic Weisbecker <frederic@...nel.org> Cc: Mauro Carvalho Chehab <mchehab@...pensource.com> Cc: Joel Fernandes <joel@...lfernandes.org> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Pavan Kondeti <pkondeti@...eaurora.org> Cc: Paul E . McKenney <paulmck@...ux.vnet.ibm.com> Cc: David S . Miller <davem@...emloft.net> Cc: Ingo Molnar <mingo@...nel.org> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Cc: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Peter Zijlstra <peterz@...radead.org> --- kernel/locking/lockdep.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 9bb39677fd97..acd82145f6a6 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -3909,13 +3909,8 @@ static void check_flags(unsigned long flags) * check if not in hardirq contexts: */ if (!hardirq_count()) { - if (softirq_count()) { - /* like the above, but with softirqs */ - DEBUG_LOCKS_WARN_ON(current->softirqs_enabled); - } else { - /* lick the above, does it taste good? */ + if (!softirq_count()) DEBUG_LOCKS_WARN_ON(!current->softirqs_enabled); - } } if (!debug_locks) -- 2.17.1
Powered by blists - more mailing lists