linux-kernel - Re: [PATCH] fat: enable .splice_write to support splice on O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Feb 2019 02:18:20 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Hou Tao <houtao1@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] fat: enable .splice_write to support splice on O_DIRECT file

Hou Tao <houtao1@...wei.com> writes:

> Now splice() on O_DIRECT-opened fat file will return -EFAULT, that is
> because the default .splice_write, namely default_file_splice_write(),
> will construct an ITER_KVEC iov_iter and dio_refill_pages() in dio path
> can not handle it.
>
> Fix it by implementing .splice_write through iter_file_splice_write().
>
> Spotted by xfs-tests generic/091.
>
> Signed-off-by: Hou Tao <houtao1@...wei.com>
> ---
>  fs/fat/file.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index 13935ee99e1e..b3bed32946b1 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -214,6 +214,7 @@ const struct file_operations fat_file_operations = {
>  #endif
>  	.fsync		= fat_file_fsync,
>  	.splice_read	= generic_file_splice_read,
> +	.splice_write	= iter_file_splice_write,
>  	.fallocate	= fat_fallocate,
>  };

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>