linux-kernel - Re: [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <155008127539.115909.8938099989804942@swboyd.mtv.corp.google.com>
Date:   Wed, 13 Feb 2019 10:07:55 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Sugaya Taichi <sugaya.taichi@...ionext.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Mark Rutland <mark.rutland@....com>,
        Shinji Kanematsu <kanematsu.shinji@...ionext.com>,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Sugaya Taichi <sugaya.taichi@...ionext.com>,
        Michael Turquette <mturquette@...libre.com>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Takao Orito <orito.takao@...ionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@...ionext.com>
Subject: Re: [PATCH v2 07/15] ndings: clock: milbeaut: add Milbeaut clock description

Quoting Stephen Boyd (2019-02-13 09:55:34)
> The subject seems to have been cut off? "ndings"?
> 
> Quoting Sugaya Taichi (2019-02-08 04:27:03)
> > diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.txt b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
> > new file mode 100644
> > index 0000000..bcfc5df
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.txt
> > @@ -0,0 +1,49 @@
> > +Milbeaut SoCs Clock Controller Binding
> > +----------------------------------------
> > +Milbeaut SoCs Clock controller is an integrated clock controller, which
> > +generates and supplies to all modules.
> > +
> > +This binding uses common clock bindings
> > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> > +
> > +Required properties:
> > +- compatible: should be one of the following:
> > +    "socionext,milbeaut-m10v-ccu" - for M10V SoC
> > +- reg: shall contain base address and length of clock registers
> > +- #clock-cells: shall be 1
> > +- clocks: shall be an external clock
> > +
> > +Example: Clock controller node:
> > +
> > +       clk: m10v-clk-ctrl@...21000 {
> > +               compatible = "socionext,milbeaut-m10v-clk-ccu";
> 
> I thought there was some length limit on compatible string names. 32
> bytes? Just barely under!
> 

Ah I'm wrong. Compatible is 128. Good.

Seems I was thinking of DT property names.