linux-kernel - Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 20:13:55 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@...ux.intel.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core

On Wed, Feb 13, 2019 at 8:02 PM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@...ux.intel.com> wrote:
> On 13-Feb-19 10:58 PM, Andy Shevchenko wrote:
> > On Wed, Feb 13, 2019 at 5:50 PM Bhardwaj, Rajneesh
> > <rajneesh.bhardwaj@...ux.intel.com> wrote:
> >> On 13-Feb-19 9:03 PM, Andy Shevchenko wrote:

> > We don't do rebasing for published changes. Only in rear cases when
> > otherwise would be worse.
> > Darren didn't respond to my question what he thinks about this case,
> > but at least it's not related to the code itself which, in my opinion,
> > decreases a severity.
>
> Thanks Andy. So if i understand correctly, you are suggesting that i
> should ignore those patches that made to "for-next" branch already?

I suggest you to rebase your local branch against latest subsystem tip
branch, resolve conflicts if any, test, and only after that send a new
version.

> So should i just send a v3 comprising of remaining 5 patches and of
> course,  addressing recent review comments?

I dunno how many patches you will get after rebasing. It might be 5,
might be more, might be less. You decide what will be in next version.
Just carefully describe the changes in the log.

-- 
With Best Regards,
Andy Shevchenko