linux-kernel - Re: [PATCH v2 18/21] ASoC: samsung: i2s: Comments clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <8e68b53f-5e19-c686-dd37-8f730ae1c256@samsung.com>
Date:   Wed, 13 Feb 2019 20:07:29 +0100
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     broonie@...nel.org, lgirdwood@...il.com, sbkim73@...sung.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 18/21] ASoC: samsung: i2s: Comments clean up

On 2/13/19 09:06, Krzysztof Kozlowski wrote:
>> @@ -742,7 +742,7 @@ static int i2s_hw_params(struct snd_pcm_substream *substream,
>>         switch (params_channels(params)) {
>>         case 6:
>>                 val |= MOD_DC2_EN;
>> -               /* fall through */
>> +               /* Fall through */

> Just to be sure - did you check whether this passes GCC
> -Wimplicit-fallthrough=3 (you need GCC v7)? It looks correct - like
> one of accepted patterns
> (https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html).

I just checked it now and with comment in upper case the warning 
is also being suppressed.

-- 
Regards,
Sylwester