linux-kernel - Re: [PATCH v14 06/15] tracing: Add hist trigger snapshot() action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1550087239.7529.1.camel@kernel.org>
Date:   Wed, 13 Feb 2019 13:47:19 -0600
From:   Tom Zanussi <zanussi@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     tglx@...utronix.de, mhiramat@...nel.org, namhyung@...nel.org,
        vedang.patel@...el.com, bigeasy@...utronix.de,
        joel@...lfernandes.org, mathieu.desnoyers@...icios.com,
        julia@...com, linux-kernel@...r.kernel.org,
        linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v14 06/15] tracing: Add hist trigger snapshot() action

Hi Steve,

On Wed, 2019-02-13 at 14:35 -0500, Steven Rostedt wrote:
> On Wed, 13 Feb 2019 14:25:51 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
> > 
> > I noticed this because we hardcode the size in memcpy. Should hard
> > code
> > it above, otherwise it looks like elt_data->comm may be something
> > other
> > than TASK_COMM_LEN.
> 
> 
> Hi Tom,
> 
> My comments on patch 5 and 6 are the only comments I have on the
> series. Could you address them and post a v15, and I'll pull them in
> and start testing them?
> 

Great, yeah I'll make all those changes and post a v15 shortly.

Thanks,

Tom

> Thanks!
> 
> -- Steve