linux-kernel - Re: [PATCH v4 6/8] dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c" compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 14:09:10 -0800
From:   Ray Jui <ray.jui@...adcom.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        Mark Rutland <mark.rutland@....com>, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Subject: Re: [PATCH v4 6/8] dt-bindings: i2c: iproc: add "brcm,iproc-nic-i2c"
 compatible string



On 2/13/2019 1:18 PM, Rob Herring wrote:
> On Mon, Feb 04, 2019 at 03:15:52PM -0800, Ray Jui wrote:
>> From: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
>>
>> Update iProc I2C binding document to add new compatible string
>> "brcm,iproc-nic-i2c". Optional property "brcm,ape-hsls-addr-mask" is
>> also added that allows configuration of the host view into the APE's
>> address for "brcm,iproc-nic-i2c"
>>
>> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
>> Signed-off-by: Ray Jui <ray.jui@...adcom.com>
>> ---
>>  Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
>> index d3a3620b1f06..02e82d20239e 100644
>> --- a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
>> +++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
>> @@ -3,7 +3,7 @@ Broadcom iProc I2C controller
>>  Required properties:
>>  
>>  - compatible:
>> -    Must be "brcm,iproc-i2c"
>> +    Must be "brcm,iproc-i2c" or "brcm,iproc-nic-i2c"
>>  
>>  - reg:
>>      Define the base and range of the I/O address space that contain the iProc
>> @@ -24,6 +24,9 @@ Optional properties:
>>      Should contain the I2C interrupt. If unspecified, driver will fall back to
>>      polling mode
>>  
>> +- brcm,ape-hsls-addr-mask:
>> +    Required for "brcm,iproc-nic-i2c". Host view of address mask into the
>> +    'APE' co-processor
> 
> What's the data type and size? What are valid values?

It's an unsigned u32 mask value. An example of a valid value is for
example 0x03400000. Do you want any of these added to the paragraph above?

> 
>>  
>>  Example:
>>  	i2c0: i2c@...08000 {
>> -- 
>> 2.17.1
>>