linux-kernel - Re: linux-next: Tree for Feb 13 (drivers/spmi/spmi-pmic-arb.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190213233609.GA6859@basecamp>
Date:   Wed, 13 Feb 2019 18:36:09 -0500
From:   Brian Masney <masneyb@...tation.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Marc Gonzalez <marc.w.gonzalez@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Stephen Boyd <sboyd@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for Feb 13 (drivers/spmi/spmi-pmic-arb.c)

On Wed, Feb 13, 2019 at 01:12:08PM -0800, Randy Dunlap wrote:
> On 2/13/19 10:31 AM, Brian Masney wrote:
> > On Wed, Feb 13, 2019 at 06:18:17PM +0100, Marc Gonzalez wrote:
> >> On 13/02/2019 17:47, Randy Dunlap wrote:
> >>
> >>> seen on i386:
> >>>
> >>> when CONFIG_IRQ_DOMAIN_HIERARCHY is not enabled:
> >>>
> >>> ../drivers/spmi/spmi-pmic-arb.c:1154:2: error: unknown field ‘activate’ specified in initializer
> >>>   .activate = qpnpint_irq_domain_activate,
> >>>   ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1154:2: warning: initialization from incompatible pointer type [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1154:2: warning: (near initialization for ‘pmic_arb_irq_domain_ops.match’) [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1155:2: error: unknown field ‘alloc’ specified in initializer
> >>>   .alloc = qpnpint_irq_domain_alloc,
> >>>   ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1155:2: warning: initialization from incompatible pointer type [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1155:2: warning: (near initialization for ‘pmic_arb_irq_domain_ops.select’) [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1156:2: error: unknown field ‘free’ specified in initializer
> >>>   .free = irq_domain_free_irqs_common,
> >>>   ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1156:10: error: ‘irq_domain_free_irqs_common’ undeclared here (not in a function)
> >>>   .free = irq_domain_free_irqs_common,
> >>>           ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1157:2: error: unknown field ‘translate’ specified in initializer
> >>>   .translate = qpnpint_irq_domain_translate,
> >>>   ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1157:2: warning: initialization from incompatible pointer type [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1157:2: warning: (near initialization for ‘pmic_arb_irq_domain_ops.unmap’) [enabled by default]
> > 
> > drivers/pinctrl/qcom/Kconfig already has this in linux-next:
> > 
> > config PINCTRL_QCOM_SPMI_PMIC
> >        tristate "Qualcomm SPMI PMIC pin controller driver"
> >        ...
> >        select IRQ_DOMAIN_HIERARCHY
> > 
> > Am I missing something else?
> 
> That kconfig symbol is not set/enabled.
> However, SPMI_MSM_PMIC_ARB=m and that is where the build error happens.
> 
> I am attaching the full randconfig file.

Ohh, I see. I should have looked closer. I initially assumed it was the
spmi-gpio driver. I'll send out a fix in a little bit.

Thanks,

Brian