linux-kernel - Re: [v5.0-rc6 regression] "perf/core: Don't WARN() for impossible ring-buffer sizes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190213233827.GA9483@leoy-ThinkPad-X240s>
Date:   Thu, 14 Feb 2019 07:38:27 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>, julien.thierry@....com,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Ingo Molnar <mingo@...nel.org>,
        Coresight ML <coresight@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [v5.0-rc6 regression] "perf/core: Don't WARN() for impossible
 ring-buffer sizes"

Hi Mathieu, Mark,

On Wed, Feb 13, 2019 at 02:26:25PM -0700, Mathieu Poirier wrote:
> Hi Mark,
> 
> CoreSight trace collection is broken on v5.0-rc6 due to this commit:
> 
> 9dff0aa95a32 perf/core: Don't WARN() for impossible ring-buffer sizes
> 
> Before:
> root@...o:/home/linaro# perf record -e cs_etm/@...70000.etr/u
> --per-thread  uname
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.036 MB perf.data ]
> root@...o:/home/linaro#
> 
> After:
> root@...o:/home/linaro# perf record -e cs_etm/@...70000.etr/u
> --per-thread  uname
> failed to mmap with 12 (Cannot allocate memory)
> root@...o:/home/linaro#
> 
> The problem is related to the order_base_2() [1] test with a size of
> 1264, stemming from nr_pages equal to 128.  The combination yields an
> order of 11, something leading directly to the error path.
> 
> The results are the same with linux-next 20190213.  This was tested on
> a Juno R0 and R1 with a 4K page configuration.  I haven't tried but
> I'm pretty sure it breaks IntelPT as well.

I noticed in another thread [1] Peter gave out the fixing for this
issue; applied this fixing on my local code and it fixes CoreSight
tracing issue.

Thanks,
Leo Yan

[1] https://lkml.org/lkml/2019/2/12/452