linux-kernel - Re: [PATCH 4.9 034/137] ARM: mmp/mmp2: dt: enable the clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4333cdaab9f550c924e47440f02f74e1c9b634fd.camel@v3.sk>
Date:   Wed, 13 Feb 2019 03:59:47 +0100
From:   Lubomir Rintel <lkundrak@...sk>
To:     Pavel Machek <pavel@....cz>, Sasha Levin <sashal@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Olof Johansson <olof@...om.net>
Subject: Re: [PATCH 4.9 034/137] ARM: mmp/mmp2: dt: enable the clock

On Tue, 2019-02-12 at 19:11 +0100, Pavel Machek wrote:
> On Tue 2019-02-12 11:50:36, Sasha Levin wrote:
> > On Mon, Feb 11, 2019 at 09:51:25PM +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > 4.9-stable review patch.  If anyone has any objections, please let me know.
> > > > 
> > > > ------------------
> > > > 
> > > > [ Upstream commit f36797ee43802b367e59f0f9a9805304a4ff0c98 ]
> > > > 
> > > > The device-tree booted MMP2 needs to enable the timer clock, otherwise
> > > > it would stop ticking when the boot finishes.
> > > > 
> > > > It can also use the clock rate from the clk, the non-DT boards need to
> > > > keep using the hardcoded rates.
> > > > 
> > > > Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> > > > Acked-by: Pavel Machek <pavel@....cz>
> > > > Signed-off-by: Olof Johansson <olof@...om.net>
> > > > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > > 
> > > While I agree this is good idea for mainline (thus my ack), I don't
> > > think it is suitable for stable, as older kernels will not run on OLPC
> > > in useful way, anyway.
> > 
> > Interesting, so OLPC doesn't run on 4.20?
> 
> These are for OLPC-1.75 (arm based). I'd be surprised if it booted
> there...
> 									Pavel

Fairly certain it doesn't boot -- even the proper DT compatible string
is not there. If it were, until 5.0-rc6 the keyboard wouldn't work,
thus the laptop would be really of pretty limited useuflness.

Lubo