linux-kernel - linux-next: manual merge of the vhost tree with the swiotlb tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 15:25:22 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dongli Zhang <dongli.zhang@...cle.com>,
        Joerg Roedel <jroedel@...e.de>
Subject: linux-next: manual merge of the vhost tree with the swiotlb tree

Hi all,

Today's linux-next merge of the vhost tree got a conflict in:

  kernel/dma/swiotlb.c

between commit:

  71602fe6d4e9 ("swiotlb: add debugfs to track swiotlb buffer usage")

from the swiotlb tree and commits:

  88eec9b0e80a ("swiotlb: Introduce swiotlb_max_mapping_size()")
  7c1fd56c53d8 ("swiotlb: Add is_swiotlb_active() function")

from the vhost tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc kernel/dma/swiotlb.c
index a01b83e95a2a,c873f9cc2146..000000000000
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@@ -678,35 -663,16 +678,49 @@@ swiotlb_dma_supported(struct device *hw
  	return __phys_to_dma(hwdev, io_tlb_end - 1) <= mask;
  }
  
 +#ifdef CONFIG_DEBUG_FS
 +
 +static int __init swiotlb_create_debugfs(void)
 +{
 +	static struct dentry *d_swiotlb_usage;
 +	struct dentry *ent;
 +
 +	d_swiotlb_usage = debugfs_create_dir("swiotlb", NULL);
 +
 +	if (!d_swiotlb_usage)
 +		return -ENOMEM;
 +
 +	ent = debugfs_create_ulong("io_tlb_nslabs", 0400,
 +				   d_swiotlb_usage, &io_tlb_nslabs);
 +	if (!ent)
 +		goto fail;
 +
 +	ent = debugfs_create_ulong("io_tlb_used", 0400,
 +				   d_swiotlb_usage, &io_tlb_used);
 +	if (!ent)
 +		goto fail;
 +
 +	return 0;
 +
 +fail:
 +	debugfs_remove_recursive(d_swiotlb_usage);
 +	return -ENOMEM;
 +}
 +
 +late_initcall(swiotlb_create_debugfs);
 +
 +#endif
++
+ size_t swiotlb_max_mapping_size(struct device *dev)
+ {
+ 	return ((size_t)1 << IO_TLB_SHIFT) * IO_TLB_SEGSIZE;
+ }
+ 
+ bool is_swiotlb_active(void)
+ {
+ 	/*
+ 	 * When SWIOTLB is initialized, even if io_tlb_start points to physical
+ 	 * address zero, io_tlb_end surely doesn't.
+ 	 */
+ 	return io_tlb_end != 0;
+ }

Content of type "application/pgp-signature" skipped