linux-kernel - Re: [PATCH] USB: musb: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 10:08:04 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bin Liu <b-liu@...com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] USB: musb: mark expected switch fall-through

On Tue, Feb 12, 2019 at 01:47:54PM -0600, Bin Liu wrote:
> Hi Greg,
> 
> On Tue, Feb 12, 2019 at 01:23:57PM -0600, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> > 
> > This patch fixes the following warning:
> > 
> > drivers/usb/musb/musb_host.c: In function ‘musb_advance_schedule’:
> > drivers/usb/musb/musb_host.c:374:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >     if (qh->mux == 1) {
> >        ^
> > drivers/usb/musb/musb_host.c:383:3: note: here
> >    case USB_ENDPOINT_XFER_ISOC:
> >    ^~~~
> > 
> > Warning level 3 was used: -Wimplicit-fallthrough=3
> > 
> > Notice that, in this particular case, the code comment is modified
> > in accordance with what GCC is expecting to find.
> > 
> > This patch is part of the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> I've closed my musb tree for v5.1-rc1, if you want to directly pick this
> patch, here is my Acked-by, or I will take it for v5.2-rc1.
> 
> Acked-by: Bin Liu <b-liu@...com>

I'll take it directly, thanks.

greg k-h