linux-kernel - Re: [PATCH 07/11] mtd: rawnand: atmel: add sam9x60 nand controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 10:54:12 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <alexandre.belloni@...tlin.com>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <Nicolas.Ferre@...rochip.com>, <Ludovic.Desroches@...rochip.com>,
        <dwmw2@...radead.org>, <computersforpeace@...il.com>,
        <bbrezillon@...nel.org>, <marek.vasut@...il.com>, <richard@....at>,
        <miquel.raynal@...tlin.com>, <lee.jones@...aro.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH 07/11] mtd: rawnand: atmel: add sam9x60 nand controller
 support



On 02/13/2019 12:39 PM, Alexandre Belloni wrote:
> Hi,
> 
> On 13/02/2019 09:00:05+0000, Tudor.Ambarus@...rochip.com wrote:
>> -	nc->ebi_csa_offs = (uintptr_t)match->data;
>> +	nc->ebi_csa = (struct atmel_smc_nand_ebi_csa_cfg *)match->data;
>>  
> 
> This cast is probably not necessary anymore as this cast a pointer to a
> pointer.
> 

it's done to discard the const qualifier from pointer target type. data is of
type const void *. nc->ebi_csa was not declared as const because below in the
same function we are modifying one of its members:

nc->ebi_csa->offs += 4;

I'll add a comment, thanks!

Cheers,
ta