linux-kernel - Re: [PATCH 2/5] tpm: Change calc_tpm2_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190213112008.GG7087@linux.intel.com>
Date:   Wed, 13 Feb 2019 13:20:08 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     bsz@...ihalf.com
Cc:     linux-efi@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, peterhuewe@....de,
        ard.biesheuvel@...aro.org, tweek@...gle.com, mingo@...nel.org,
        hdegoede@...hat.com, leif.lindholm@...aro.org, mw@...ihalf.com
Subject: Re: [PATCH 2/5] tpm: Change calc_tpm2_event_size signature

On Mon, Feb 11, 2019 at 03:30:49PM +0100, bsz@...ihalf.com wrote:
> From: Bartosz Szczepanek <bsz@...ihalf.com>
> 
> Pass tcg_efi_specid_event as an argument instead of tcg_pcr_event, as the
> former is what is actually needed to compute event size. tcg_pcr_event
> structure describes TPM event log header (even though its name), from where
> efispecid can be extracted -- it seems cleaner and less misleading to do it
> out of calc_tpm2_event_size function.
> 
> Also, use ssize_t instead of int for event log size.
> 
> Signed-off-by: Bartosz Szczepanek <bsz@...ihalf.com>

Unreviewable without call sites. NAK.

/Jarkko