linux-kernel - Re: [PATCH -next] net: ipvlan_l3s: fix kconfig unmet dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bc4ec7b-8373-12bc-5f89-3d85415bc5d7@iogearbox.net>
Date:   Wed, 13 Feb 2019 12:23:09 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Mahesh Bandewar <maheshb@...gle.com>,
        David Miller <davem@...emloft.net>
Cc:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] net: ipvlan_l3s: fix kconfig unmet dependency
 warning

On 02/13/2019 03:02 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix the kconfig warning in IPVLAN_L3S when neither INET nor IPV6
> is enabled:
> 
> WARNING: unmet direct dependencies detected for NET_L3_MASTER_DEV
>   Depends on [n]: NET [=y] && (INET [=n] || IPV6 [=n])
>   Selected by [y]:
>   - IPVLAN_L3S [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETFILTER [=y]
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Mahesh Bandewar <maheshb@...gle.com>
> ---
> Seen in mmotm but applies to linux-next.
> 
>  drivers/net/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- mmotm-2019-0212-1537.orig/drivers/net/Kconfig
> +++ mmotm-2019-0212-1537/drivers/net/Kconfig
> @@ -147,6 +147,7 @@ config MACVTAP
>  
>  config IPVLAN_L3S
>  	depends on NETFILTER
> +	depends on INET || IPV6 # same as NET_L3_MASTER_DEV

Thanks for the fix! Lets just do the following instead ...

    depends on IPVLAN

... and we should be all set. Please submit against net-next, thanks!

>  	def_bool y
>  	select NET_L3_MASTER_DEV
>  
> 
>