linux-kernel - RE: [PATCH 1/3] arm64: mmu: update paging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 11:49:18 +0000
From:   Peng Fan <peng.fan@....com>
To:     Mark Rutland <mark.rutland@....com>
CC:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "yaojun8558363@...il.com" <yaojun8558363@...il.com>,
        "cpandya@...eaurora.org" <cpandya@...eaurora.org>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "van.freenix@...il.com" <van.freenix@...il.com>
Subject: RE: [PATCH 1/3] arm64: mmu: update paging_init comments

Hi Mark,

> -----Original Message-----
> From: Mark Rutland [mailto:mark.rutland@....com]
> Sent: 2019年2月13日 19:19
> To: Peng Fan <peng.fan@....com>
> Cc: catalin.marinas@....com; will.deacon@....com;
> ard.biesheuvel@...aro.org; yaojun8558363@...il.com;
> cpandya@...eaurora.org; robin.murphy@....com;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> van.freenix@...il.com
> Subject: Re: [PATCH 1/3] arm64: mmu: update paging_init comments
> 
> On Wed, Feb 13, 2019 at 09:37:24AM +0000, Peng Fan wrote:
> > The comments has not been changed since the function introduced, but
> > the function has been changed dramatically, so update the comments to
> > reflect the code.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  arch/arm64/mm/mmu.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index
> > d6b6f1b169bb..065202da3ad2 100644
> > --- a/arch/arm64/mm/mmu.c
> > +++ b/arch/arm64/mm/mmu.c
> > @@ -655,8 +655,8 @@ static void __init map_kernel(pgd_t *pgdp)  }
> >
> >  /*
> > - * paging_init() sets up the page tables, initialises the zone memory
> > - * maps and sets up the zero page.
> > + * paging_init() sets up the page tables, switch ttbr1 from
> > + init_pg_dir
> > + * to swapper_pg_dir, free init_pg_dir memblock and permit memblock
> resizing.
> >   */
> 
> I think that it would be better to remove the comment entirely. This doesn't
> explain the intent, or rationale, and all this information is obvious from a
> straight-line reading of the code.
> 
> If you remove the comment instead:
> 
> Acked-by: Mark Rutland <mark.rutland@....com>

I'll remove the comment with you a-b added.

Thanks,
Peng.
> 
> Mark.
> 
> >  void __init paging_init(void)
> >  {
> > --
> > 2.16.4
> >