linux-kernel - Re: [PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b62cd57c-e348-60a4-f99b-e3a6562f6ef8@criteo.com>
Date:   Wed, 13 Feb 2019 12:19:58 +0000
From:   Erwan Velu <e.velu@...teo.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
CC:     Erwan Velu <erwanaliasr1@...il.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "open list:INTEL PSTATE DRIVER" <linux-pm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] cpufreq: intel_pstate: Reporting reasons why driver
 prematurely exit


Le 13/02/2019 à 11:34, Rafael J. Wysocki a écrit :
> So a single "no PCCH" message for this whole function should be sufficient.

Let's do that.

[...]
> And what did turn out to be the problem?
>
> Anyway, pr_info() should be sufficient IMO.

You should be pretty aware of 95d6c0857e54b788982746071130d822a795026b ;)

Depending if we have or not this patch, intel_pstate engage itself or not.

When engaged, we have to perform some configuration that the other state 
doesn't imply.


I'm updating the patch this way than send a v6.

I just let intel_pstate_msrs_not_valid() in pr_warn() as this one is not 
supposed to be a "normal" case.


Thanks for your time & reviews.


> Many thanks for your contribution!

My pleasure !

Erwan,