linux-kernel - Re: [PATCH] blktrace: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190213085938.4a21e2ee@gandalf.local.home>
Date:   Wed, 13 Feb 2019 08:59:38 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Ingo Molnar <mingo@...hat.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] blktrace: mark expected switch fall-through

On Tue, 12 Feb 2019 15:03:11 -0600
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> kernel/trace/blktrace.c: In function ‘blk_trace_ioctl’:
> kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    start = 1;
>    ~~~~~~^~~
> kernel/trace/blktrace.c:726:2: note: here
>   case BLKTRACESTOP:
>   ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  kernel/trace/blktrace.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index fac0ddf8a8e2..e1c6d79fb4cc 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
>  #endif
>  	case BLKTRACESTART:
>  		start = 1;
> +		/* fall through */
>  	case BLKTRACESTOP:
>  		ret = __blk_trace_startstop(q, start);
>  		break;