linux-kernel - Re: [PATCH] tracing: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190213090217.52eb48e8@gandalf.local.home>
Date:   Wed, 13 Feb 2019 09:02:17 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] tracing: Mark expected switch fall-through

On Tue, 12 Feb 2019 15:08:03 -0600
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> kernel/trace/trace_events_filter.c: In function ‘predicate_parse’:
> kernel/trace/trace_events_filter.c:494:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
>      if (next[1] == next[0]) {
>         ^
> kernel/trace/trace_events_filter.c:498:4: note: here
>     default:
>     ^~~~~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 

Thanks, but I've already applied this patch:

 http://lkml.kernel.org/r/20190114203039.16535-2-malat@debian.org

I just haven't run my queue through my tests to push it to linux-next
yet.

-- Steve

> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  kernel/trace/trace_events_filter.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> index 27821480105e..eb694756c4bb 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -495,6 +495,7 @@ predicate_parse(const char *str, int nr_parens, int nr_preds,
>  					ptr++;
>  					break;
>  				}
> +				/* fall through */
>  			default:
>  				parse_error(pe, FILT_ERR_TOO_MANY_PREDS,
>  					    next - str);