linux-kernel - Re: [PATCH v3] i2c: core-smbus: don't trace smbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190214170230.dvm4i2wxmgxij4bg@ninjato>
Date:   Thu, 14 Feb 2019 18:02:30 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     John Sperbeck <jsperbeck@...gle.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com, rostedt@...dmis.org
Subject: Re: [PATCH v3] i2c: core-smbus: don't trace smbus_reply data on
 errors

On Tue, Feb 12, 2019 at 07:40:57PM -0800, John Sperbeck wrote:
> If an smbus transfer fails, there's no guarantee that the output
> buffer was written.  So, avoid trying to show the output buffer when
> tracing after an error.  This was 'mostly harmless', but would trip
> up kasan checking if left-over cruft in byte 0 is a large length,
> causing us to read from unwritten memory.
> 
> Signed-off-by: John Sperbeck <jsperbeck@...gle.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)