linux-kernel - Re: [PATCH v2] exec: load_script: Allow interpreter argument truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214174612.GB8150@redhat.com>
Date:   Thu, 14 Feb 2019 18:46:13 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Samuel Dionne-Riel <samuel@...nne-riel.com>,
        Richard Weinberger <richard.weinberger@...il.com>,
        Graham Christensen <graham@...hamc.com>,
        Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] exec: load_script: Allow interpreter argument
 truncation

On 02/14, Kees Cook wrote:
>
> v2:
>  - fix 1-byte-too-early-bail-out in truncation detection (Oleg)
>  - add Samuel's "tested" tag

Looks correct...

but you know, I'll try to read this patch again tomorrow after sleep.

And I can't believe this code can't be simplified... but let me repeat
that I tried and failed.

Oleg.