linux-kernel - [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Feb 2019 16:47:41 +0100
From:   Rask Ingemann Lambertsen <rask@...melder.dk>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        linux-kernel@...r.kernel.org
Cc:     Olliver Schinagl <oliver@...inagl.nl>,
        linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug

An obvious copy/paste bug was introduced with the conversion to sybolic
register masks. The result is contradictory output like this:

vcc-dram: Bringing 1100000uV into 1450000-1450000uV
vcc-dram: 1450 <--> 1550 mV at 1050 mV

This patch fixes it:

vcc-dram: 1450 <--> 1550 mV at 1500 mV

Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks")
Signed-off-by: Rask Ingemann Lambertsen <rask@...melder.dk>
---
 drivers/regulator/axp20x-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 1b51d557ab55..f03cae440f7f 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -791,7 +791,7 @@ static const struct regulator_desc axp806_regulators[] = {
 			AXP806_DCDCA_V_CTRL, AXP806_DCDCA_V_CTRL_MASK,
 			AXP806_PWR_OUT_CTRL1, AXP806_PWR_OUT_DCDCA_MASK),
 	AXP_DESC(AXP806, DCDCB, "dcdcb", "vinb", 1000, 2550, 50,
-		 AXP806_DCDCB_V_CTRL, AXP806_DCDCB_V_CTRL,
+		 AXP806_DCDCB_V_CTRL, AXP806_DCDCB_V_CTRL_MASK,
 		 AXP806_PWR_OUT_CTRL1, AXP806_PWR_OUT_DCDCB_MASK),
 	AXP_DESC_RANGES(AXP806, DCDCC, "dcdcc", "vinc",
 			axp806_dcdca_ranges, AXP806_DCDCA_NUM_VOLTAGES,
-- 
2.20.1