linux-kernel - Re: [PATCH v6 0/5] i2c: ocores: improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214030733.GG24589@lunn.ch>
Date:   Thu, 14 Feb 2019 04:07:33 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Federico Vaga <federico.vaga@...n.ch>
Cc:     Peter Korsgaard <peter@...sgaard.com>,
        Peter Rosin <peda@...ntia.se>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/5] i2c: ocores: improvements

On Mon, Feb 11, 2019 at 05:49:08PM +0100, Federico Vaga wrote:
> This patch set provides improvements to the i2c-ocore driver.
> 
> [V5 -> V6]
> - remove redundant code introduced in V5 (double read control register)
> 
> [V4 -> V5]
> - deterministic status of IEN bit in register "CONTROL" at the end of
>   ocores_init()
> - more style fixes
> 
> [V3 -> V4]
> - add reviews-by/tested-by
> - add comment to justify the formula in
>     udelay((8 * 1000) / i2c->bus_clock_khz);

Hi Federico

It looks like all the reviewed-by: tags disappeared from v5.

Can you add them back again, and then we can probably merge this
patchset.

	Thanks
		Andrew