linux-kernel - Re: [PATCH] scsi: qlogicpti: Use of_node_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq11s4bqcxe.fsf@oracle.com>
Date:   Wed, 13 Feb 2019 22:14:21 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Rob Herring <robh@...nel.org>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, Meelis Roos <mroos@...ux.ee>
Subject: Re: [PATCH] scsi: qlogicpti: Use of_node_name_eq for node name comparisons

Rob,

> -	qpti->is_pti = strcmp(qpti->prom_name, "QLGC,isp");
> +	qpti->is_pti = !of_node_name_eq(op->dev.of_node, "QLGC,isp");

The apparent polarity inversion made me blink but it appears to be
correct (is_pti is set if it's not an isp controller). Makes me wonder
if the driver is doing the right thing for a "SUNW,isp", though...

Meelis: Do you have anything that identifies itself as SUNW,isp?

In any case: Applied to 5.1/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering