linux-kernel - Re: [PATCH] devfreq: Use of_node_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cc4b5a3-c4ad-46a9-2856-3ed67c6755d3@samsung.com>
Date:   Thu, 14 Feb 2019 12:49:38 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH] devfreq: Use of_node_name_eq for node name comparisons

Hi Rob,

On 19. 2. 14. 오전 1:09, Rob Herring wrote:
> On Wed, Dec 5, 2018 at 1:50 PM Rob Herring <robh@...nel.org> wrote:
>>
>> Convert string compares of DT node names to use of_node_name_eq helper
>> instead. This removes direct access to the node name pointer.
>>
>> For instances using of_node_cmp, this has the side effect of now using
>> case sensitive comparisons. This should not matter for any FDT based
>> system which all of these are.
>>
>> Cc: Chanwoo Choi <cw00.choi@...sung.com>
>> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
>> Cc: Kyungmin Park <kyungmin.park@...sung.com>
>> Cc: Kukjin Kim <kgene@...nel.org>
>> Cc: Krzysztof Kozlowski <krzk@...nel.org>
>> Cc: linux-pm@...r.kernel.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-samsung-soc@...r.kernel.org
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  drivers/devfreq/devfreq-event.c     | 2 +-
>>  drivers/devfreq/event/exynos-ppmu.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Can someone apply this please.

Myungjoo picked up this patch[1] on devfreq.git
but has not yet sent the pull request.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/commit/?h=for-next&id=0c1e8ce295acc3becc95e393e88a9a6da233074f

> 
>>
>> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
>> index d67242d87744..87e93406d7cd 100644
>> --- a/drivers/devfreq/devfreq-event.c
>> +++ b/drivers/devfreq/devfreq-event.c
>> @@ -240,7 +240,7 @@ struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(struct device *dev,
>>         }
>>
>>         list_for_each_entry(edev, &devfreq_event_list, node) {
>> -               if (!strcmp(edev->desc->name, node->name))
>> +               if (of_node_name_eq(node, edev->desc->name))
>>                         goto out;
>>         }
>>         edev = NULL;
>> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
>> index c61de0bdf053..c2ea94957501 100644
>> --- a/drivers/devfreq/event/exynos-ppmu.c
>> +++ b/drivers/devfreq/event/exynos-ppmu.c
>> @@ -529,7 +529,7 @@ static int of_get_devfreq_events(struct device_node *np,
>>                         if (!ppmu_events[i].name)
>>                                 continue;
>>
>> -                       if (!of_node_cmp(node->name, ppmu_events[i].name))
>> +                       if (of_node_name_eq(node, ppmu_events[i].name))
>>                                 break;
>>                 }
>>
>> --
>> 2.19.1
>>
> 
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics