linux-kernel - Re: [PATCH 0/1] mips: loongson64: move EC header to include/asm/mach-loongson64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190214082729.GA24527@localhost.localdomain>
Date:   Thu, 14 Feb 2019 16:27:30 +0800
From:   Tom Li <tomli@...li.me>
To:     Aaro Koskinen <aaro.koskinen@....fi>
Cc:     linux-mips@...r.kernel.org, Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhc@...ote.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/1] mips: loongson64: move EC header to
 include/asm/mach-loongson64

> Hi,
> > Yifeng Li (1):
> >   mips: loongson64: move EC header to include/asm/mach-loongson64
> 
> This probably should be MFD driver under drivers/mfd. It's a longer
> road, though...
> 
> A.

The problem of converting it to a MFD driver, is that there's still
something doesn't fit together.

The core CPU idle code in loongson64/common calls the platform code
in arch/mips/loongson64/lemote-2f to set up an interrupt handler in
i8259, and inspect if the source of interrupt is an lid open event by
querying the ENE KB3310B controller. But normally an MFD driver is
only used to share the underlying hardware between multiple drivers
in each subsystem, not to provide shared utilily functions.

But after reading drivers/mfd for a while, apparently we do have drivers
that "EXPORT_SYMBOL()" to other parts of the kernel. So I think it's
a matter of fact that can be discussed with MFD maintainers.

So yes, I'm converting all the EC code to a MFD driver. I have withdrawn
this patch, do not merge it. The new MFD patch is coming soon.

Thanks,
Tom Li

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)