linux-kernel - Re: [PATCH v5 07/11] power: supply: max77650: add support for battery charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214103944.GC6132@amd>
Date:   Thu, 14 Feb 2019 11:39:44 +0100
From:   Pavel Machek <pavel@....cz>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-input@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-pm@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v5 07/11] power: supply: max77650: add support for
 battery charger

Hi!

> +#define MAX77650_CHG_OFF			0x00
> +#define MAX77650_CHG_PREQ			0x01
> +
> +#define MAX77650_CHGIN_UNDERVOLTAGE_LOCKOUT	0x00
> +#define MAX77650_CHGIN_OVERVOLTAGE_LOCKOUT	0x01
> +#define MAX77650_CHGIN_OKAY			0x11

Thanks for doing this.

> +#define MAX77650_CHG_ON_CURR			0x02
> +#define MAX77650_CHG_ON_CURR_JEITA		0x03
> +#define MAX77650_CHG_ON_VOLT			0x04
> +#define MAX77650_CHG_ON_VOLT_JEITA		0x05
> +#define MAX77650_CHG_ON_TOPOFF			0x06
> +#define MAX77650_CHG_ON_TOPOFF_JEITA		0x07
> +#define MAX77650_CHG_DONE			0x08
> +#define MAX77650_CHG_DONE_JEITA			0x09
> +#define MAX77650_CHG_SUSP_PREQ_TIM_FAULT	0x0a
> +#define MAX77650_CHG_SUSP_FAST_CHG_TIM_FAULT	0x0b
> +#define MAX77650_CHG_SUSP_BATT_TEMP_FAULT	0x0c
> +
> +#define MAX77650_CHARGER_CHGIN_DTLS_MASK	GENMASK(3, 2)
> +#define MAX77650_CHARGER_CHGIN_DTLS_BITS(_reg) \
> +		(((_reg) & MAX77650_CHARGER_CHGIN_DTLS_MASK) >> 2)

But I guess these could use similar treatment?
							Pavel
							
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)