linux-kernel - Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9713bff0-8f1e-99c2-240d-aec627136cd9@huawei.com>
Date:   Thu, 14 Feb 2019 19:35:15 +0800
From:   Zenghui Yu <yuzenghui@...wei.com>
To:     Marc Zyngier <marc.zyngier@....com>
CC:     <tglx@...utronix.de>, <jason@...edaemon.net>,
        <shankerd@...eaurora.org>, <wanghaibin.wang@...wei.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for
 Device table

Hi Marc,

On 2019/2/14 18:46, Marc Zyngier wrote:
> On Sun, 10 Feb 2019 05:24:10 +0000,
> Zenghui Yu <yuzenghui@...wei.com> wrote:
>>
>> In current logic, its_parse_indirect_baser() will be invoked twice
>> when allocating Device tables. Add a *break* to omit the unnecessary
>> and annoying (might be ...) invoking.
>>
>> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
>> ---
>>   drivers/irqchip/irq-gic-v3-its.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
>> index db20e99..9f529a6 100644
>> --- a/drivers/irqchip/irq-gic-v3-its.c
>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>> @@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its)
>>   			indirect = its_parse_indirect_baser(its, baser,
>>   							    psz, &order,
>>   							    its->device_ids);
>> +			break;
>> +
>>   		case GITS_BASER_TYPE_VCPU:
>>   			indirect = its_parse_indirect_baser(its, baser,
>>   							    psz, &order,
> 
> Nice catch. I've applied this to irqchip-next with the Fixes tag and a
> Cc stable.
> 

Thanks for picking it up!

Zenghui