linux-kernel - RE: linux-next: build warning after merge of the rdma tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3F128C9216C9B84BB6ED23EF16290AFB750DA68D@CRSMSX101.amr.corp.intel.com>
Date:   Thu, 14 Feb 2019 12:35:34 +0000
From:   "Wan, Kaike" <kaike.wan@...el.com>
To:     Doug Ledford <dledford@...hat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Jason Gunthorpe <jgg@...lanox.com>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>
Subject: RE: linux-next: build warning after merge of the rdma tree



> -----Original Message-----
> From: Doug Ledford [mailto:dledford@...hat.com]
> Sent: Wednesday, February 13, 2019 7:21 PM
> To: Stephen Rothwell <sfr@...b.auug.org.au>; Jason Gunthorpe
> <jgg@...lanox.com>
> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@...r.kernel.org>; Wan, Kaike
> <kaike.wan@...el.com>; Gustavo A. R. Silva <gustavo@...eddedor.com>;
> Kees Cook <keescook@...omium.org>
> Subject: Re: linux-next: build warning after merge of the rdma tree
> 
> On Thu, 2019-02-14 at 11:18 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the rdma tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/infiniband/hw/hfi1/qp.c: In function 'hfi1_setup_wqe':
> > drivers/infiniband/hw/hfi1/qp.c:328:3: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> >    hfi1_setup_tid_rdma_wqe(qp, wqe);
> >    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/infiniband/hw/hfi1/qp.c:329:2: note: here
> >   case IB_QPT_UC:
> >   ^~~~
> >
> > Introduced by commit
> >
> >   f1ab4efa6d32 ("IB/hfi1: Enable TID RDMA READ protocol")
> >
> > I get this warning because I am building with -Wimplicit-fallthrough
> > in attempt to catch new additions early.  The gcc warning can be
> > turned off by adding a /* fall through */ comment at the point the
> > fall through happens (assuming that the fall through is intentional).
> >
> 
> Thanks Stephen, we'll sort it and make an appropriate fixup patch.
> 
> Kaike?

It's intentional. We will add a "/* fall through */" comment as a fixup patch.

Kaike
> 
> --
> Doug Ledford <dledford@...hat.com>
>     GPG KeyID: B826A3330E572FDD
>     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD