linux-kernel - Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214131116.GW9224@smile.fi.intel.com>
Date:   Thu, 14 Feb 2019 15:11:16 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Xiang Xiao <xiaoxiang781216@...il.com>
Cc:     rdunlap@...radead.org, gregkh@...uxfoundation.org,
        alexander.shishkin@...ux.intel.com, ohad@...ery.com,
        bjorn.andersson@...aro.org, wendy.liang@...inx.com,
        arnaud.pouliquen@...com, kumar.gala@...aro.org,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guiding Li <liguiding@...econe.net>
Subject: Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

On Thu, Feb 14, 2019 at 03:09:40PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote:

> > +	/* append the message after '\n' to the buffer */
> 
> > +	if (copied != 0) {

Missed comment

if (copied)

> > +	}

-- 
With Best Regards,
Andy Shevchenko