linux-kernel - Re: [PATCH V4 7/9] x86/alternative: Batch of patch operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214143030.GB4423@zn.tnic>
Date:   Thu, 14 Feb 2019 15:30:30 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jiri Kosina <jkosina@...e.cz>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Chris von Recklinghausen <crecklin@...hat.com>,
        Jason Baron <jbaron@...mai.com>, Scott Wood <swood@...hat.com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Clark Williams <williams@...hat.com>, x86@...nel.org
Subject: Re: [PATCH V4 7/9] x86/alternative: Batch of patch operations

On Thu, Feb 14, 2019 at 09:06:20AM -0500, Steven Rostedt wrote:
> Although you did say above that "patch" is an overloaded term. Also, I
> do find the current name rather descriptive.

When you look at "text_to_poke" as a struct name, you go, WTF is that?
The whole text? Some of it?

It should have the word "location" in it, to be clearer IMO.

> 	void *trampoline;

Well, it ain't a trampoline either. It is a "temporary location to go to while
patching is going on". Now make that a member name!

:-)))

> But they are named after you! "bp_" :-)

Uuh, you shouldn't have! :-)

Then they *must* be changed immediately!

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.