linux-kernel - Re: [PATCH] mfd: sc27xx: Use SoC compatible string for PMIC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuKBym0A126Yo+=hQdZDb1U4ivO_g6YawxzLU-KjZdfbvg@mail.gmail.com>
Date:   Thu, 14 Feb 2019 10:00:56 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Lyra Zhang <zhang.lyra@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: sc27xx: Use SoC compatible string for PMIC devices

On Wed, 13 Feb 2019 at 22:28, Arnd Bergmann <arnd@...db.de> wrote:
>
> On Wed, Feb 13, 2019 at 1:57 PM Baolin Wang <baolin.wang@...aro.org> wrote:
> >
> > We should use SoC compatible string in stead of wildcard string for
> > PMIC child devices.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>
> Looks good. I had a look at arch/arm64/boot/dts/sprd/sc2731.dtsi
> as well, which contains lines such as
>
> compatible = "sprd,sc27xx-efuse", "sprd,sc2731-efuse";
>
> which fortunately work with both variants of the driver.
> Just to make sure we have the same understanding though:
>
> - Other drivers will leave out the 27xx part and just do
>   compatible = sprd,sc2732-efuse", "sprd,sc2731-efuse";
>
> - When you specific a generic name (such as the sc2731 part),
>   the more specific one (e.g. sc2732) needs to come /first/.
>   The current DT appears to have those mixed up.

Yes, that's the conclusion we made. And I've send patches to remove
the 27xx part in drivers. Thanks for your help.

-- 
Baolin Wang
Best Regards