linux-kernel - Re: [PATCH] tools build: Add test-reallocarray.c to test-all.c to fix the build Was: Re: reallocarray failure on centos:7 superseded by raw data API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Feb 2019 16:56:19 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Alexei Starovoitov <ast@...com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>, bpf@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools build: Add test-reallocarray.c to test-all.c to
 fix the build Was: Re: reallocarray failure on centos:7 superseded by raw
 data API

On Thu, Feb 14, 2019 at 12:30:18PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

>     
>     Reported-by: Jin Yao <yao.jin@...ux.intel.com>
>     Cc: Adrian Hunter <adrian.hunter@...el.com>
>     Cc: Alexei Starovoitov <ast@...com>
>     Cc: Daniel Borkmann <daniel@...earbox.net>
>     Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
>     Cc: Jiri Olsa <jolsa@...nel.org>
>     Cc: Namhyung Kim <namhyung@...nel.org>
>     Cc: Song Liu <songliubraving@...com>
>     Cc: Yonghong Song <yhs@...com>
>     Fixes: 531b014e7a2f ("tools: bpf: make use of reallocarray")
>     Link: https://lkml.kernel.org/n/tip-aonqku8axii8rxki5g11w40b@git.kernel.org
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>


Acked-by: Jiri Olsa <jolsa@...nel.org>

jirka

> 
> diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
> index 74329957553a..e903b86b742f 100644
> --- a/tools/build/feature/test-all.c
> +++ b/tools/build/feature/test-all.c
> @@ -174,6 +174,10 @@
>  # include "test-libaio.c"
>  #undef main
>  
> +#define main main_test_reallocarray
> +# include "test-reallocarray.c"
> +#undef main
> +
>  int main(int argc, char *argv[])
>  {
>  	main_test_libpython();
> @@ -214,6 +218,7 @@ int main(int argc, char *argv[])
>  	main_test_sdt();
>  	main_test_setns();
>  	main_test_libaio();
> +	main_test_reallocarray();
>  
>  	return 0;
>  }
> diff --git a/tools/build/feature/test-reallocarray.c b/tools/build/feature/test-reallocarray.c
> index 8170de35150d..8f6743e31da7 100644
> --- a/tools/build/feature/test-reallocarray.c
> +++ b/tools/build/feature/test-reallocarray.c
> @@ -6,3 +6,5 @@ int main(void)
>  {
>  	return !!reallocarray(NULL, 1, 1);
>  }
> +
> +#undef _GNU_SOURCE