linux-kernel - Re: [PATCH] staging: android: ion: Use low_order_gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN=25QPaHd9qpH-OK+0LL951=0hwf1frsC7H1O9hGimsyVUKVg@mail.gmail.com>
Date:   Thu, 14 Feb 2019 10:08:53 +0800
From:   jing xia <jing.xia.mail@...il.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Sumit Semwal <sumit.semwal@...aro.org>, gregkh@...uxfoundation.org,
        arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        joel@...lfernandes.org, christian@...uner.io,
        puck.chen@...ilicon.com, devel@...verdev.osuosl.org,
        dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
        linux-kernel@...r.kernel.org, yuming.han@...soc.com,
        zhaoyang.huang@...soc.com, orson.zhai@...soc.com,
        wenan.hu@...soc.com
Subject: Re: [PATCH] staging: android: ion: Use low_order_gfp_flags for
 smaller allocations

Thanks.

On Thu, Feb 14, 2019 at 2:27 AM Laura Abbott <labbott@...hat.com> wrote:
>
> On 2/11/19 11:09 PM, Jing Xia wrote:
> > gfp_flags is always set high_order_gfp_flags even if allocations of
> > order 0 are made.But for smaller allocations, the system should be able
> > to reclaim some memory.
> >
> > Signed-off-by: Jing Xia <jing.xia@...soc.com>
> > Reviewed-by: Yuming Han <yuming.han@...soc.com>
> > Reviewed-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
> > Reviewed-by: Orson Zhai <orson.zhai@...soc.com>
> > ---
> >   drivers/staging/android/ion/ion_system_heap.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> > index 0383f75..20f2103 100644
> > --- a/drivers/staging/android/ion/ion_system_heap.c
> > +++ b/drivers/staging/android/ion/ion_system_heap.c
> > @@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)
> >   static int ion_system_heap_create_pools(struct ion_page_pool **pools)
> >   {
> >       int i;
> > -     gfp_t gfp_flags = low_order_gfp_flags;
> >
> >       for (i = 0; i < NUM_ORDERS; i++) {
> >               struct ion_page_pool *pool;
> > +             gfp_t gfp_flags = low_order_gfp_flags;
> >
> >               if (orders[i] > 4)
> >                       gfp_flags = high_order_gfp_flags;
> >
>
> This was already submitted in
> https://lore.kernel.org/lkml/1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com/T/#u
> (I'm also very behind on Ion e-mail and need to catch up...)
>
> Laura