linux-kernel - Re: [PATCH 1/3] kallsyms: add static qualifiers where missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASnRfOOX2oKkPp_Ehe7QG3bMLvR_Sr6CEw91zoqJaqkRQ@mail.gmail.com>
Date:   Thu, 14 Feb 2019 11:09:31 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     nixiaoming <nixiaoming@...wei.com>,
        Jan Beulich <JBeulich@...e.com>,
        Cao jin <caoj.fnst@...fujitsu.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Mathias Krause <minipli@...glemail.com>
Subject: Re: [PATCH 1/3] kallsyms: add static qualifiers where missing

On Mon, Feb 4, 2019 at 10:57 AM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> Fix the following sparse warnings:
>
> scripts/kallsyms.c:65:5: warning: symbol 'token_profit' was not declared. Should it be static?
> scripts/kallsyms.c:68:15: warning: symbol 'best_table' was not declared. Should it be static?
> scripts/kallsyms.c:69:15: warning: symbol 'best_table_len' was not declared. Should it be static?
>
> Also, remove 'inline' from is_arm_mapping_symbol(). The compiler
> will inline it anyway when it is appropriate to do so.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Applied to linux-kbuild.

> ---
>
>  scripts/kallsyms.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 77cebad..fc00bb0 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -62,11 +62,11 @@ static int all_symbols = 0;
>  static int absolute_percpu = 0;
>  static int base_relative = 0;
>
> -int token_profit[0x10000];
> +static int token_profit[0x10000];
>
>  /* the table that holds the result of the compression */
> -unsigned char best_table[256][2];
> -unsigned char best_table_len[256];
> +static unsigned char best_table[256][2];
> +static unsigned char best_table_len[256];
>
>
>  static void usage(void)
> @@ -80,7 +80,7 @@ static void usage(void)
>   * This ignores the intensely annoying "mapping symbols" found
>   * in ARM ELF files: $a, $t and $d.
>   */
> -static inline int is_arm_mapping_symbol(const char *str)
> +static int is_arm_mapping_symbol(const char *str)
>  {
>         return str[0] == '$' && strchr("axtd", str[1])
>                && (str[2] == '\0' || str[2] == '.');
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada