linux-kernel - Re: [PATCH v2] tracing: Fix number of entries in trace header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190214112818.701347c4@gandalf.local.home>
Date:   Thu, 14 Feb 2019 11:28:18 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Quentin Perret <quentin.perret@....com>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org, joelaf@...gle.com,
        smuckle@...gle.com, dietmar.eggemann@....com
Subject: Re: [PATCH v2] tracing: Fix number of entries in trace header

On Thu, 14 Feb 2019 15:29:50 +0000
Quentin Perret <quentin.perret@....com> wrote:

> The following commit
> 
>   441dae8f2f29 ("tracing: Add support for display of tgid in trace output")

Thanks, I'll take a look at this.

> 
> removed the call to print_event_info() from print_func_help_header_irq()
> which results in the ftrace header not reporting the number of entries
> written in the buffer. As this wasn't the original intent of the patch,
> re-introduce the call to print_event_info() to restore the orginal
> behaviour.
> 
> Fixes: 441dae8f2f29 ("tracing: Add support for display of tgid in trace output")
> Cc: 4.13+ <stable@...r.kernel.org> # v4.13+

Note, with the "Fixes:" tag, adding the version number is obsolete. Just

Cc: stable@...r.kernel.org

is sufficient.

-- Steve

> Signed-off-by: Quentin Perret <quentin.perret@....com>
> Acked-by: Joel Fernandes <joelaf@...gle.com>
> ---
>  kernel/trace/trace.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index c521b7347482..c4238b441624 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3384,6 +3384,8 @@ static void print_func_help_header_irq(struct trace_buffer *buf, struct seq_file
>  	const char tgid_space[] = "          ";
>  	const char space[] = "  ";
>  
> +	print_event_info(buf, m);
> +
>  	seq_printf(m, "#                          %s  _-----=> irqs-off\n",
>  		   tgid ? tgid_space : space);
>  	seq_printf(m, "#                          %s / _----=> need-resched\n",