linux-kernel - Re: [PATCH v2 perf,bpf 01/11] perf, bpf: consider events with attr.bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190215180406.GH5784@redhat.com>
Date:   Fri, 15 Feb 2019 16:04:06 -0200
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Song Liu <songliubraving@...com>
Cc:     Netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>,
        Peter Zijlstra <peterz@...radead.org>,
        "jolsa@...nel.org" <jolsa@...nel.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>
Subject: Re: [PATCH v2 perf,bpf 01/11] perf, bpf: consider events with
 attr.bpf_event as side-band events

Em Fri, Feb 15, 2019 at 05:02:02PM +0000, Song Liu escreveu:
> 
> 
> > On Feb 15, 2019, at 6:14 AM, Arnaldo Carvalho de Melo <acme@...hat.com> wrote:
> > 
> > Em Thu, Feb 14, 2019 at 03:58:40PM -0800, Song Liu escreveu:
> >> Events with bpf_event should be considered as side-band event, as they
> >> carry information about BPF programs.
> >> 
> >> Fixes: 6ee52e2a3fe4 ("perf, bpf: Introduce PERF_RECORD_BPF_EVENT")
> >> Signed-off-by: Song Liu <songliubraving@...com>
> >> ---
> >> kernel/events/core.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/kernel/events/core.c b/kernel/events/core.c
> >> index 0a8dab322111..9403bdda5f8c 100644
> >> --- a/kernel/events/core.c
> >> +++ b/kernel/events/core.c
> >> @@ -4238,7 +4238,8 @@ static bool is_sb_event(struct perf_event *event)
> >> 	if (attr->mmap || attr->mmap_data || attr->mmap2 ||
> >> 	    attr->comm || attr->comm_exec ||
> >> 	    attr->task || attr->ksymbol ||
> 				^ here

how come, I looked after context_switch, that came before, have to
replace my glasses... :-)
> 
> >> -	    attr->context_switch)
> >> +	    attr->context_switch ||
> >> +	    attr->bpf_event)
> > 
> > What about attr->ksymbol?
 
> It is already included up there. attr->bpf_event was missed initially 
> because we didn't use events with bpf_event but not ksymbol. With this 
> set, the polling thread only has bpf_event, so we need this fix. 

Ok, I'll get this one merged asap.

- Arnaldo