linux-kernel - Re: [PATCH] scripts/gdb: fix linux constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <07923abd-117d-2a33-2700-7db0840eacad@ideasonboard.com>
Date:   Fri, 15 Feb 2019 20:24:08 +0000
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Dan Robertson <danlrobertson89@...il.com>,
        Jan Kiszka <jan.kiszka@...mens.com>
Cc:     felipe.balbi@...ux.intel.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/gdb: fix linux constants

Hi Dan,

Thank you for the patch,

On 15/02/2019 19:17, Dan Robertson wrote:
> The linux constants MS_RDONLY, MS_SYNCHRONOUS, MS_MANDLOCK, MS_DIRSYNC,
> MS_NOATIME, and MS_NODIRATIME were previously defined in linux/fs.h.
> Following e262e32d6bde0f77fb0c95d977482fc872c51996 the constants are
> now defined in uapi/linux/mount.h. The new location of the defined
> constants needs to be included in constants.py template in order for the
> correct constants to be generated.
> 

This commit was pipped to the post by a similar patch [0] from Felipe Balbi

[0]
https://lore.kernel.org/lkml/20190215112938.25574-1-felipe.balbi@linux.intel.com/

Combined together they would form a complete patch, but this one could
do with the Fixes: tag such as

Fixes: e262e32d6bde "vfs: Suppress MS_* flag defs within the kernel
unless explicitly enabled"

With a Fixes: tag:

Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>

> Signed-off-by: Dan Robertson <dan@...obertson.com>
> ---
>  scripts/gdb/linux/constants.py.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index 7aad82406422..6c164761d986 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -12,9 +12,9 @@
>   *
>   */
>  
> -#include <linux/fs.h>

Whereas Felipe's patch does not include this change (which I think it
looks like it should)


How should we proceed with these two competing patches?
Any preference from anyone?

Content wise, I feel like this one is in the lead - just missing the
Fixes: tag, but Felipe's won the race...


--
Kieran

>  #include <linux/mount.h>
>  #include <linux/of_fdt.h>
> +#include <uapi/linux/mount.h>
>  
>  /* We need to stringify expanded macros so that they can be parsed */
>  
> @@ -36,7 +36,7 @@
>  
>  import gdb
>  
> -/* linux/fs.h */
> +/* uapi/linux/mount.h */
>  LX_VALUE(MS_RDONLY)
>  LX_VALUE(MS_SYNCHRONOUS)
>  LX_VALUE(MS_MANDLOCK)
> 


-- 
Regards
--
Kieran