linux-kernel - Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a0a443e-2895-d22f-8dee-bc5e40c31481@huawei.com>
Date:   Fri, 15 Feb 2019 10:13:19 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <gaoxiang25@...wei.com>,
        Sheng Yong <shengyong1@...wei.com>
CC:     <gregkh@...uxfoundation.org>, <linux-erofs@...ts.ozlabs.org>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <chao@...nel.org>, Miao Xie <miaoxie@...wei.com>,
        "fangwei (I)" <fangwei1@...wei.com>
Subject: Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr
 array

On 2019/2/14 15:10, Gao Xiang wrote:
> 
> 
> On 2019/2/14 14:46, Sheng Yong wrote:
>> If it fails to read a shared xattr page, the inode's shared xattr array
>> is not freed. The next time the inode's xattr is accessed, the previously
>> allocated array is leaked.

Nice catch!

>>
>> Signed-off-by: Sheng Yong <shengyong1@...wei.com>
> 
> LGTM,
> 
> Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
> Cc: <stable@...r.kernel.org> # 4.19+
> Reviewed-by: Gao Xiang <gaoxiang25@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

> 
> [and there is also another race condition in it, but different root cause.
> let me fix it later independently...]
> 
> Thanks,
> Gao Xiang
> 
> .
>