linux-kernel - [tip:perf/core] perf header: Get rid of write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-a9aeb87b98badb55ec28dfcae8a8ce127d6208f5@git.kernel.org>
Date:   Fri, 15 Feb 2019 01:51:04 -0800
From:   tip-bot for Jiri Olsa <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     acme@...hat.com, namhyung@...nel.org, linux-kernel@...r.kernel.org,
        hpa@...or.com, mingo@...nel.org,
        alexander.shishkin@...ux.intel.com, peterz@...radead.org,
        tglx@...utronix.de, jolsa@...nel.org
Subject: [tip:perf/core] perf header: Get rid of write_it label

Commit-ID:  a9aeb87b98badb55ec28dfcae8a8ce127d6208f5
Gitweb:     https://git.kernel.org/tip/a9aeb87b98badb55ec28dfcae8a8ce127d6208f5
Author:     Jiri Olsa <jolsa@...nel.org>
AuthorDate: Wed, 13 Feb 2019 13:32:43 +0100
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Thu, 14 Feb 2019 15:18:09 -0300

perf header: Get rid of write_it label

Simplifying the code a bit.

Signed-off-by: Jiri Olsa <jolsa@...nel.org>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/20190213123246.4015-8-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/header.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index dec6d218c31c..f1508adefc16 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1042,11 +1042,9 @@ static int write_cpuid(struct feat_fd *ff,
 	int ret;
 
 	ret = get_cpuid(buffer, sizeof(buffer));
-	if (!ret)
-		goto write_it;
+	if (ret)
+		return -1;
 
-	return -1;
-write_it:
 	return do_write_string(ff, buffer);
 }