linux-kernel - Re: [PATCH v3 3/9] s390: ap: new vfio_ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <019ca60e-996a-bd02-c859-3f9891083d0c@linux.ibm.com>
Date:   Fri, 15 Feb 2019 10:58:17 +0100
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     Cornelia Huck <cohuck@...hat.com>
Cc:     borntraeger@...ibm.com, alex.williamson@...hat.com,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        kvm@...r.kernel.org, frankja@...ux.ibm.com, akrowiak@...ux.ibm.com,
        pasic@...ux.ibm.com, david@...hat.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, freude@...ux.ibm.com, mimu@...ux.ibm.com
Subject: Re: [PATCH v3 3/9] s390: ap: new vfio_ap_queue structure

On 15/02/2019 10:37, Cornelia Huck wrote:
> On Thu, 14 Feb 2019 14:51:03 +0100
> Pierre Morel <pmorel@...ux.ibm.com> wrote:
> 
>> The AP interruptions are assigned on a queue basis
>> and we need some information neloging to the queue
> 
> s/neloging/belonging/
> 
>> to handle interuptions.
> 
> s/interuptions/interruptions/
> 
>>
>> We add a new structure vfio_ap_queue, to hold per
>> queue information useful to handle interruptions.
>>
>> - apqn: AP queue number (defined here)
>> - isc : Interrupt subclass (defined later)
>> - nib : notification information byte (defined later)
> 
> So, you basically simply want quick access to these? Makes sense.
> 
>>
>> The vfio_ap_queue structure is allocated when the vfio_ap_driver
>> is probed and added as driver data to the ap_queue device.
>> It is free on remove.
> 
> s/free/freed/
> 
>>
>> The structure is linked to the matrix_dev host device.
> 
> Hm, I don't quite follow?

Sorry, do not try to, this has been left from a previous internal version.
I will suppress this

> 
>>
>> Signed-off-by: Pierre Morel <pmorel@...ux.ibm.com>
>> Reviewed-by: Tony Krowiak <akrowiak@...ux.ibm.com>
>> ---
>>   drivers/s390/crypto/vfio_ap_drv.c     | 23 ++++++++++++++++++++++-
>>   drivers/s390/crypto/vfio_ap_private.h |  3 +++
>>   2 files changed, 25 insertions(+), 1 deletion(-)
> 
> Patch looks reasonable; might make sense to squash it with later
> patches (still need to read).
> 


-- 
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany