linux-kernel - Re: [PATCH] video: fbdev: vesafb: fix indentation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Feb 2019 02:00:27 -0800
From:   Joe Perches <joe@...ches.com>
To:     Colin King <colin.king@...onical.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: vesafb: fix indentation issue

On Tue, 2019-02-12 at 13:29 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There are a couple of statements that are indented too deeply, fix
> this by removing tabs. Also add a space after a comma to clean up
> a cppcheck warning.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/video/fbdev/vesafb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c
> index 528fe917dd49..b7388e25aa2a 100644
> --- a/drivers/video/fbdev/vesafb.c
> +++ b/drivers/video/fbdev/vesafb.c
> @@ -336,8 +336,8 @@ static int vesafb_probe(struct platform_device *dev)
>  		printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal);
>  		if (pmi_base[3]) {
>  			printk(KERN_INFO "vesafb: pmi: ports = ");
> -				for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
> -					printk("%x ",pmi_base[i]);
> +			for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
> +				printk("%x ", pmi_base[i]);
>  			printk("\n");
>  			if (pmi_base[i] != 0xffff) {
>  				/*

Perhaps you could also use pr_cont too because otherwise this
emits each printk on separate lines.