linux-kernel - Re: [PATCH] ASoC: samsung: odroid: Ensure proper sample rate on pri/sec PCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <54683fa7-6a07-5706-5b8a-ce7be5d02646@samsung.com>
Date:   Fri, 15 Feb 2019 12:32:13 +0100
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     broonie@...nel.org, lgirdwood@...il.com, sbkim73@...sung.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: samsung: odroid: Ensure proper sample rate on
 pri/sec PCM

On 2/15/19 08:24, Krzysztof Kozlowski wrote:
> Is this the fix for
> "aplay: set_params:1403: Unable to install hw params:"
> which appeared in today's next (so after your last round of patches get merged)?
> https://krzk.eu/#/builders/1/builds/3093/steps/24/logs/stdio

No, but I have just prepared a fix for that one. I should have done
sound playback/recording test for a scenario without DTS updates rather
than just looking at card initialization completion.
Without DTS changes there will be 1 or 2 DAPM routes missing. I'm going to
post a patch adding missing DAPM routes in the card driver for backwards
compatibility.

> Also, since yesterday (so with previous rounds of patches) the audss
> rebind freezes entire kernel:
> https://krzk.eu/#/builders/1/builds/3093/steps/25/logs/stdio
> https://krzk.eu/#/builders/1/builds/3093/steps/25/logs/serial0
> 
> It is not important test but it was always passing in my suite.

The reason might be that I used platform_device_del() rather than
platform_device_unregister(). I will post other fix I have for scenario 
with multiple "multi-I2S" devices, it should also be a solution for 
that rebind issue.

-- 
Regards,
Sylwester