linux-kernel - RE: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB488080895C871B6B3ABA571D96600@VI1PR04MB4880.eurprd04.prod.outlook.com>
Date:   Fri, 15 Feb 2019 14:41:47 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Shawn Guo <shawnguo@...nel.org>, Leo Li <leoyang.li@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Alexandru Marginean <alexandru.marginean@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO
 support



>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Friday, February 15, 2019 3:35 PM
>To: Claudiu Manoil <claudiu.manoil@....com>
>Cc: Shawn Guo <shawnguo@...nel.org>; Leo Li <leoyang.li@....com>; David S .
>Miller <davem@...emloft.net>; Alexandru Marginean
><alexandru.marginean@....com>; linux-arm-kernel@...ts.infradead.org;
>devicetree@...r.kernel.org; netdev@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Subject: Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO
>support
>
>On Fri, Feb 15, 2019 at 12:10:14PM +0200, Claudiu Manoil wrote:
>> Each ENETC PF has its own MDIO interface, the corresponding
>> MDIO registers are mapped in the ENETC's Port register block.
>> The current patch adds a driver for these PF level MDIO buses,
>> so that each PF can manage directly its own external link.
>>
>> Signed-off-by: Alex Marginean <alexandru.marginean@....com>
>> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>
>> ---
>> v2 - used readx_poll_timeout()
>>    - added mdio node child to the port node
>
>Hi Claudiu
>
>Please document this in the device tree binding.
>

Hi,
I don't really see what bindings would need to be documented, as the node
names and properties used so far are common.  Like, the "mdio" node name
is common, the enetc ports are "pci" nodes, nothing special for these.
What's missing?

Regards,
Claudiu