linux-kernel - Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <143411a8-385d-2cce-9211-22ba7db25a15@oracle.com>
Date:   Fri, 15 Feb 2019 10:03:59 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Oleksandr Andrushchenko <andr2000@...il.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        jgross@...e.com
Cc:     Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
Subject: Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while
 dma-bufs are in use

On 2/14/19 9:23 AM, Oleksandr Andrushchenko wrote:
>  
>  /* DMA buffer export support. */
> @@ -311,6 +317,7 @@ static void dmabuf_exp_release(struct kref *kref)
>  
>  	dmabuf_exp_wait_obj_signal(gntdev_dmabuf->priv, gntdev_dmabuf);
>  	list_del(&gntdev_dmabuf->next);
> +	fput(gntdev_dmabuf->priv->filp);
>  	kfree(gntdev_dmabuf);
>  }
>  
> @@ -423,6 +430,7 @@ static int dmabuf_exp_from_pages(struct gntdev_dmabuf_export_args *args)
>  	mutex_lock(&args->dmabuf_priv->lock);
>  	list_add(&gntdev_dmabuf->next, &args->dmabuf_priv->exp_list);
>  	mutex_unlock(&args->dmabuf_priv->lock);
> +	get_file(gntdev_dmabuf->priv->filp);

Not fget()?

-boris