linux-kernel - Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjzX73spBTB3AEbgppUzoGPb7iVphc3oJZ5evXmkZ2eRw@mail.gmail.com>
Date:   Fri, 15 Feb 2019 08:08:30 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Samuel Dionne-Riel <samuel@...nne-riel.com>,
        Richard Weinberger <richard.weinberger@...il.com>,
        Graham Christensen <graham@...hamc.com>,
        Michal Hocko <mhocko@...e.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] exec: load_script: Do not exec truncated interpreter path

On Fri, Feb 15, 2019 at 8:05 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> And even that doesn't really fix it, because what it really wants is
> "strnchr()" (to stop at a NUL too). Which doesn't exist.

.. actually it does exist in the kernel, and I should read all my
emails before writing new ones, because you had a patch in one of your
later emails that looks fine to me and used it.

Although I think I'd prefer that inline  helper model instead to make
things more legible.

Would you be willing to make a frankenpatch that combines our two approaches?

                       Linus