linux-kernel - Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190216152128.GO2217@ZenIV.linux.org.uk>
Date:   Sat, 16 Feb 2019 15:21:28 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        x86@...nel.org, "H . J . Lu" <hjl.tools@...il.com>
Subject: Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with
 offset == -1

On Sat, Feb 16, 2019 at 04:15:28PM +0100, Aurelien Jarno wrote:
> On 2019-01-12 20:07, Aurelien Jarno wrote:
> > On 2018-12-06 20:05, Aurelien Jarno wrote:
> > > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
> > > writev syscalls when offset == -1. Therefore the compat code should
> > > check for offset before calling do_compat_preadv64 and
> > > do_compat_pwritev64. This is the case for the preadv2 and pwritev2
> > > syscalls, but handling of offset == -1 is missing in their 64-bit
> > > equivalent.
> > > 
> > > This patch fixes that, calling do_compat_readv and do_compat_writev when
> > > offset == -1. This fixes the following glibc tests on x32:
> > >  - misc/tst-preadvwritev2
> > >  - misc/tst-preadvwritev64v2
> > > 
> > > Cc: Alexander Viro <viro@...iv.linux.org.uk>
> > > Cc: H.J. Lu <hjl.tools@...il.com>
> > > Signed-off-by: Aurelien Jarno <aurelien@...el32.net>
> > > ---
> > >  fs/read_write.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > 
> > Any news about this patch?
> > 
> 
> Ping.

Applied